Skip to content

Conversation

@joshblack
Copy link
Contributor

@joshblack joshblack commented Jan 29, 2025

Update our runners to use ubuntu-22.04 instead of ubuntu-latest since our karma dependencies that launch Chrome do not work on ubuntu-24

Comment on lines +11 to +25
runs-on: ubuntu-22.04

steps:
- uses: actions/checkout@v1
- name: Use Node.js
uses: actions/setup-node@v1
with:
node-version: '20.x'
- name: npm install, build, and test
run: |
npm install
npm run build --if-present
npm test
env:
CI: true
- uses: actions/checkout@v1
- name: Use Node.js
uses: actions/setup-node@v1
with:
node-version: '20.x'
- name: npm install, build, and test
run: |
npm install
npm run build --if-present
npm test
env:
CI: true

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
@joshblack joshblack marked this pull request as ready for review January 29, 2025 16:57
@joshblack joshblack requested a review from a team as a code owner January 29, 2025 16:57
@joshblack joshblack merged commit c158e69 into main Jan 29, 2025
4 checks passed
@joshblack joshblack deleted the chore/pin-ubuntu-runners branch January 29, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants